Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Key Import / Export Format Does Not Match Spec #2

Closed
babolivier opened this issue Feb 10, 2019 · 3 comments
Closed

E2E Key Import / Export Format Does Not Match Spec #2

babolivier opened this issue Feb 10, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@babolivier
Copy link

System:

  • Nheko version: 0.6.3
  • Installation method: AppImage
  • Operating System: Arch Linux
  • Desktop Environment: Gnome Shell (3.30.2)

Actual behavior

decrypt_exported_sessions: ciphertext too small when trying to import E2EE keys from Riot.

Expected behavior

Keys are imported.

Steps to reproduce

  • Export keys from Riot using the "Export E2E room keys" button
  • Import the file in nheko

Logs

Nothing related in nheko logs.
@babolivier
Copy link
Author

Might be worth noticing that @rek2:matrix.org also reported that error a few hours ago in #nheko-reborn:matrix.org.

@babolivier babolivier changed the title "decrypt_exported_sessions: ciphertext" when importing keys from Riot "decrypt_exported_sessions: ciphertext too small" when importing keys from Riot Feb 10, 2019
@redsky17 redsky17 transferred this issue from Nheko-Reborn/nheko Feb 10, 2019
@redsky17 redsky17 added the bug Something isn't working label Feb 10, 2019
@redsky17
Copy link
Member

So the main issue here is that nheko and Riot's key formats are different. Nheko currently doesn't follow the spec here:
https://matrix.org/docs/spec/client_server/unstable.html#key-export-format

I have been working on this and am nearly finished, but there are still some quirks I'm working out.

@redsky17 redsky17 changed the title "decrypt_exported_sessions: ciphertext too small" when importing keys from Riot E2E Key Import / Export Format Does Not Match Spec Mar 20, 2019
@redsky17 redsky17 mentioned this issue Mar 20, 2019
Closed
@deepbluev7
Copy link
Member

This is fixed afaik!

jevolk pushed a commit to jevolk/mtxclient that referenced this issue Apr 15, 2020
@redsky17
Remove the code that removed paragraph tags from markdown -> html.
55883ec 
This fixes Nheko-Reborn#2, but reverts mujx#438.  I do not think mujx#438 was a
valid issue, as it complained about the display of valid HTML on riot,
which speaks more to how Riot styles things than about an issue in
nheko itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@redsky17 @babolivier @deepbluev7