-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist tag restriction on characters #4
Comments
Hello @sriharsha-y! Thanks for reporting! Could you please tell me which tag version do you tried to write? And what do you mean fails, is it runtime exception, or smth. else? Anyway, if you tried to write ID3v1.x, it should truncate your string up to 30 characters. It's expected behaviour according to id3v1 specification. |
updated COMM tag decoder made test for COMM frame
Hi @NiKoTron, it does not throw any runtime exception. But it fails to write the tag and when i try to read the file it does not have any meta data in it (mp3 file did not get corrupted though). I used ID3v2.4 Will try to upgrade to the latest version and check. |
@sriharsha-y you could also check this test case. dart-tags/test/dart_tags_test.dart Line 249 in f5b3242
|
@sriharsha-y, is it ok? could I close this issue? |
When i try to include a string greater than or equal to 46 bytes, the writing fails on that mp3 file. It may be true for other tags as well, but observed this on artist tag as am having quite lengthy strings in there.
Example artist string which writes successfully:
Ilaiyaraaja, K. S. Chithra, S. P. Balasubrahmanyam
Example artist string which fails:
Ilaiyaraaja, K. S. Chithra, S. P. BalasubrahmanyamT
The text was updated successfully, but these errors were encountered: