Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist tag restriction on characters #4

Closed
sriharsha-y opened this issue Jun 1, 2019 · 4 comments
Closed

Artist tag restriction on characters #4

sriharsha-y opened this issue Jun 1, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@sriharsha-y
Copy link

When i try to include a string greater than or equal to 46 bytes, the writing fails on that mp3 file. It may be true for other tags as well, but observed this on artist tag as am having quite lengthy strings in there.

Example artist string which writes successfully:

Ilaiyaraaja, K. S. Chithra, S. P. Balasubrahmanyam

Example artist string which fails:

Ilaiyaraaja, K. S. Chithra, S. P. BalasubrahmanyamT

@NiKoTron NiKoTron self-assigned this Jul 21, 2019
@NiKoTron
Copy link
Owner

Hello @sriharsha-y! Thanks for reporting! Could you please tell me which tag version do you tried to write? And what do you mean fails, is it runtime exception, or smth. else?

Anyway, if you tried to write ID3v1.x, it should truncate your string up to 30 characters. It's expected behaviour according to id3v1 specification.

NiKoTron added a commit that referenced this issue Jul 21, 2019
updated COMM tag decoder
made test for COMM frame
@sriharsha-y
Copy link
Author

sriharsha-y commented Jul 24, 2019

Hi @NiKoTron, it does not throw any runtime exception. But it fails to write the tag and when i try to read the file it does not have any meta data in it (mp3 file did not get corrupted though). I used ID3v2.4

Will try to upgrade to the latest version and check.

@NiKoTron
Copy link
Owner

NiKoTron commented Jul 24, 2019

@sriharsha-y you could also check this test case.
UPD:

test(' Artist tag restriction on characters [#4]', () async {

@NiKoTron
Copy link
Owner

@sriharsha-y, is it ok? could I close this issue?

@NiKoTron NiKoTron added the bug Something isn't working label Jul 30, 2019
@NiKoTron NiKoTron closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants