Fix calc in framesize (header vs frame) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @frankdenouter! Thanks a lot for the report and PR! I've tested it and so everything looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for all the work in the dart-tags library!
I noticed the tags I wrote to mp3 files did not show up in iTunes (or in Finder) in macOS. Especially when it had a picture as well.
I found out your library calculates 7-bit integer tag-sizes for both tag header and frame header. However it seems like the frame header has to be calculated with 8-bit integer tag-sizes: n10v/id3v2#13 (comment)
I made some changes to match this way of calculating the tag-sizes and all the tags are shown correctly now in iTunes and Finder on macOS. I needed to change one of the test-assets (id3v24.mp3) to match the tag-sizes.