Handle linefeeds #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "works", but it's not pretty, it's buggy, and, well, bleh.
They were clobbering each other, because we assumed they all took up one line, instead of the actual amount print had to spread them over.
0 times crap still equals zero!
Fix that, so printing a single char isn't interpreted as failure...
Padding, centering, & both now work with LF reflowing.
Also, we don't care about available_cols, we've already diagnosed it at the beginning, and it cannot change.
Revert the actual code changes that never should have made it to the previous commit... Ooops.
It'd been a while ;o).
So, expand the hextoc Python script for MINIMUM EFFORT! :D
Now you can basically blindly c/p, there's no hand-tweaking needed.
Now you *really* can do it blinfolded ;p.
|
Meaning if you want to print your own stuff with linefeeds, get something else to handle the escape code conversion. i.e., |
|
The LF character gets rendered as a blank space, and I'm keeping it that way, for... reasons. (It makes padding prettier, and the code simpler to deal with). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in, the LF character (0x0A), not the escape code (\n).