Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add check for CHOST #39

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Makefile: add check for CHOST #39

merged 1 commit into from
Oct 3, 2019

Conversation

jdek
Copy link
Contributor

@jdek jdek commented Oct 3, 2019

Generally, cross compilation toolchain prefixes include the '-' at the end. Don't want to change your setup, so just fallback to check a more standard CHOST cross compile if CROSS_TC is unset.

@pgaskin
Copy link
Contributor

pgaskin commented Oct 3, 2019

I agree that CROSS_TC is less standard than CHOST (I've only seen it in NiLuJe's stuff), but the only place I've seen CHOST is in Gentoo stuff and a few projects. But, I've seen CROSS_PREFIX a bit more, and CROSS_COMPILE is used in the Linux kernel (with the dash).

@jdek
Copy link
Contributor Author

jdek commented Oct 3, 2019

I'm not really bothered if you want to call it CHOST, CROSS_PREFIX or CROSS_COMPILE, just that it doesn't add an extra -. Which would you merge?

@NiLuJe
Copy link
Owner

NiLuJe commented Oct 3, 2019

Yeah, CHOST is out because it has a very specific meaning in Gentoo, and you basically shouldn't ever set it yourself anywhere ;).

@NiLuJe
Copy link
Owner

NiLuJe commented Oct 3, 2019

I have an extremely vague preference for CROSS_PREFIX, since it's also set in my own envs, but, since I'm usually using CROSS_TC myself, I have no strong opinion, both CROSS_PREFIX or CROSS_COMPILE would be fine with me ;).

Generally, cross compilation toolchain prefixes include the '-' at the end.
@jdek
Copy link
Contributor Author

jdek commented Oct 3, 2019

I set it as CROSS_COMPILE so it's similar to the kernel.

@NiLuJe
Copy link
Owner

NiLuJe commented Oct 3, 2019

That's perfectly fine with me, thanks! ;).

@NiLuJe NiLuJe merged commit cf3b833 into NiLuJe:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants