ci(release): release for linux and darwin (arm64 and amd64) #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helder-moreira
force-pushed
the
ci/release-all-archs
branch
4 times, most recently
from
278c681
to
43b7650
Compare
helder-moreira
force-pushed
the
ci/release-all-archs
branch
from
43b7650
to
93f07dc
Compare
k-yang
reviewed
Feb 1, 2023
| - -mod=readonly | ||
| ldflags: | ||
| - -s -w -X main.commit={{.Commit}} -X main.date={{ .CommitDate }} -X github.com/cosmos/cosmos-sdk/version.Name=nibiru -X github.com/cosmos/cosmos-sdk/version.AppName=nibid -X github.com/cosmos/cosmos-sdk/version.Version={{ .Version }} -X github.com/cosmos/cosmos-sdk/version.Commit={{ .Commit }} -X github.com/tendermint/tendermint/version.TMCoreSemVer={{ .Env.TM_VERSION }} | ||
| - -linkmode=external |
There was a problem hiding this comment.
You don't need the -extldflags '-Wl,-z,muldefs -static -lm'?
k-yang
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
This PR updates
goreleaserconfig to cross-compilenibidfor:To accomplish it, changes to wasmvm repo are required in order to build static lib for
macOS. These changes are applied on our own fork here.Meanwhile I opened a PR on wasmvm repo with these changes, and if they are accepted we can hopefully switch back to their repo on next version (v1.2.0).Purpose
Why is this PR important?
Any Cosmos blockchain that uses wasmvm ended up not building for
macOSanymore because only a dynamic lib is provided. Although it is unlikely that validators want to validate onmacOS, users should still be able to getnibidbinary to connect to the blockchain and perform queries and transactions.