Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use cache for based on the go.sum for dependencies for faster GH action execution #1653

Merged
merged 21 commits into from
Nov 1, 2023

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Oct 30, 2023

Purpose

The first few minutes of each of our test-based GitHub actions go toward fetching the same dependencies more often than not.

We aren't gaining anything by fetching everything from scratch on each run. Instead, we can create a hash based on the go.sum and store the Golang deps to spend less time waiting on CI runs.


Screenshot of the behavior prior to this change:

wk45-n2120-chrome_WRjR

Unique-Divine and others added 11 commits October 27, 2023 16:57
commit 5a0347a
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Sat Oct 28 16:57:44 2023 -0500

    test(simapp): flag retrieval must be inside the  fn

commit 65d43d3
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Sat Oct 28 16:43:33 2023 -0500

    test: make it so that simulations don't need to be fitered for explicitly

commit 932cfac
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Sat Oct 28 16:17:50 2023 -0500

    test fix to use correct bech32 prefix

commit 484e0b2
Merge: de8acbf 43e3afd
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Fri Oct 27 17:38:14 2023 -0500

    Merge branch 'realu/consistent-integration-suite' of https://github.com/NibiruChain/nibiru into realu/consistent-integration-suite

commit de8acbf
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Fri Oct 27 17:38:03 2023 -0500

    linter

commit 43e3afd
Merge: 6a1a459 68d4d57
Author: Unique Divine <51418232+Unique-Divine@users.noreply.github.com>
Date:   Fri Oct 27 17:13:51 2023 -0500

    Merge branch 'master' into realu/consistent-integration-suite

commit 6a1a459
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Fri Oct 27 17:03:05 2023 -0500

    change log

commit c2028d3
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Fri Oct 27 16:57:55 2023 -0500

    test: refactors cli.network suites with 'Integration' to use common function
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1653 (65a173b) into master (2b99ca7) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

❗ Current head 65a173b differs from pull request most recent head b5e3139. Consider uploading reports for the commit b5e3139 to get more accurate results

@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
+ Coverage   74.25%   74.28%   +0.02%     
==========================================
  Files         191      191              
  Lines       15099    15096       -3     
==========================================
+ Hits        11212    11214       +2     
+ Misses       3256     3251       -5     
  Partials      631      631              
Files Coverage Δ
x/spot/client/testutil/suite.go 97.93% <100.00%> (+0.38%) ⬆️
x/common/testutil/cases.go 70.00% <40.00%> (+70.00%) ⬆️

@jgimeno jgimeno merged commit 4a8c848 into master Nov 1, 2023
8 checks passed
@jgimeno jgimeno deleted the realu/ci-go-deps-cache branch November 1, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Completed
Development

Successfully merging this pull request may close these issues.

2 participants