Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registerCustomRenderer #17

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Add registerCustomRenderer #17

merged 2 commits into from
Nov 8, 2020

Conversation

dkilfoyle
Copy link
Contributor

For issue #16

@dkilfoyle
Add registerCustomRenderer
6f05fa2 
Makes sure custom renderers are inserted into the renderers array before  GenericNodeRenderer
@dkilfoyle
Import GenericNodeRenderer
91365de 
Needed for instanceof test
@coveralls
Copy link

Pull Request Test Coverage Report for Build 225

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 82.1%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nodeRendererContainer.js 0 7 0.0%
Totals Coverage Status
Change from base Build 224: -0.6%
Covered Lines: 704
Relevant Lines: 811
💛 - Coveralls

@Nic30 Nic30 merged commit 017dfc5 into Nic30:master Nov 8, 2020
@Nic30
Copy link
Owner

Nic30 commented Nov 8, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkilfoyle @coveralls @Nic30