Toolset - Make NSSEditor.compileCurrentScript use Editor.save to write to RIM files etc. Fixes: #68 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th3w1zard1
changed the title
added 2 commits
March 10, 2024 22:22
Print 'compiling script from nsseditor' before compile, not after.
JoeNotCharles
force-pushed
the
fix_nss_build
branch
from
8277bdd
to
e0d9241
Compare
JoeNotCharles
changed the title
JoeNotCharles
commented
Mar 11, 2024
JoeNotCharles
commented
Mar 11, 2024
|
|
||
| msg = "Could not convert to bytes - nsseditor.build()" | ||
| raise ValueError(msg) | ||
| return compiled_bytes, b"" |
There was a problem hiding this comment.
Not sure how to do stacked changes in github: this commit is also in #72 which should be pulled first.
|
This needs a some reworking, withdrawing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSSEditor.build returns a bogus error after compileScript succeeds. Saving of compiled scripts works find if it just returns the data to the caller.