Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to look for NSS files before decompiling NCS #78

Closed

Conversation

JoeNotCharles
Copy link
Contributor

@JoeNotCharles JoeNotCharles commented Mar 13, 2024

<when opening an NCS resource, let the user pick an NSS from Vanilla_KOTOR_Script_Source instead of decompiling
implemented in PR> #75

@JoeNotCharles JoeNotCharles changed the title Load nss before nsc Add a setting to look for NSS files before decompiling NCS Mar 13, 2024
@th3w1zard1
Copy link
Collaborator

Looks good to me. Worked fine during testing. Please let me know when you'd like this merged. Not sure if you're planning any extra features here or whatnot.

@JoeNotCharles
Copy link
Contributor Author

JoeNotCharles commented Mar 14, 2024 via email

@th3w1zard1
Copy link
Collaborator

I won't have time to work on it more for a while, so might as well merge it now. The biggest thing it's missing is checking that the NSS matches the NCS for safety, which is why I turned the setting off by default, but I think we can merge it as a use-at-your-own-risk feature like RIM saving

That logic alone will be a pain to write, maybe @NickHugi could take a look as the NCS objects are part of his compiler code.

@th3w1zard1
Copy link
Collaborator

idea improved upon and implemented in another PR.

@th3w1zard1 th3w1zard1 closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants