Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boards Manager install support #9

Merged
merged 1 commit into from
May 31, 2015
Merged

Add Boards Manager install support #9

merged 1 commit into from
May 31, 2015

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 29, 2015

Adds Boards Manager install support.
NicoHood added a commit that referenced this pull request May 31, 2015
@NicoHood NicoHood merged commit 38bd73a into NicoHood:master May 31, 2015
@NicoHood
Copy link
Owner

Thanks again!

@per1234 per1234 deleted the per1234-boards-manager-support branch May 31, 2015 20:15
@per1234
Copy link
Contributor Author

per1234 commented May 31, 2015

You're welcome. Let me know if you release a new version and want me to add it to the JSON index.

@NicoHood
Copy link
Owner

NicoHood commented Jun 1, 2015

Would you please be so kind to check this?
#10 (comment)

@per1234
Copy link
Contributor Author

per1234 commented Jun 1, 2015

I hadn't noticed before that HoodLoader2 requires the HID core because I already had it installed. I'm thinking it would be better to add HID-Project to this JSON file so that both of them will be available for install in the Boards Manager by adding only one URL to preferences. I'm happy to add it in and submit another pull request, just let me know if you want me to proceed.

@NicoHood
Copy link
Owner

NicoHood commented Jun 2, 2015

Nah.
What if people install HID project and HL2 which includes the HID Project once more?

Its fine right now

@per1234
Copy link
Contributor Author

per1234 commented Jun 2, 2015

What if people install HID project and HL2 which includes the HID Project once more?

You could just use the same Boards manager URL for both projects and then that wouldn't be a problem. I agree it works fine as it is though.

@NicoHood
Copy link
Owner

NicoHood commented Jun 4, 2015

No thanks.

@NicoHood
Copy link
Owner

Are you able to add this for the 2.0.5 branch as well? Do I first need to push it to master?
https://github.com/NicoHood/HoodLoader2/tree/dev_205

@per1234
Copy link
Contributor Author

per1234 commented Sep 26, 2015

Are you able to add this for the 2.0.5 branch as well?

Pull request submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants