Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different Readingmodes #42

Merged
merged 13 commits into from
Jul 12, 2021
Merged

Support different Readingmodes #42

merged 13 commits into from
Jul 12, 2021

Conversation

NicoHood
Copy link
Owner

@NicoHood NicoHood commented Jul 9, 2021

@mizuyoukanao check this out. I've corrected the files accordingly. Can you please test this PR? What reading mode does pokemon XD use, so I can document that this mode is 100% tested? Did you also test the other modes?

Superceeds #25 #31 and #34

@NicoHood
Copy link
Owner Author

NicoHood commented Jul 9, 2021

@DinsFire64 @trevor403 can you guys please also test this?

@mizuyoukanao
Copy link
Contributor

I've been testing Pokemon XD (mode0).
I can press all buttons and sticks and it seems to be stable.
(There was one bug where setting yAxis/cyAxis to 0 caused the same behavior as 255 in the game, but this is just a Pokemon XD specific bug and should work fine with other software that uses mode0).

@NicoHood
Copy link
Owner Author

NicoHood commented Jul 9, 2021

Do you know other software that uses mode 0 (or 1, 2, 4, 5, 6)? Maybe we need to fix this 0->255 "Bug"?

@mizuyoukanao
Copy link
Contributor

mizuyoukanao commented Jul 9, 2021

Sorry, I don't know of any software that uses anything other than mode0 and 3, and I don't have any...
The bug with 0 being 255 only happens in Pokemon XD and can be worked around by setting 1 instead of 0. Other game does not have this problem, so a fix for this is probably not necessary.
reference

@NicoHood
Copy link
Owner Author

NicoHood commented Jul 9, 2021

What do you mean by "other software"? Which game?

@NicoHood NicoHood merged commit b72c8a8 into master Jul 12, 2021
@NicoHood
Copy link
Owner Author

I just merged this PR as I do not expect it to cause much additional trouble. It increases the sketch size by ~150 bytes, due to the additional convert method.

@NicoHood NicoHood deleted the readingmodes branch July 12, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants