-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different Readingmodes #42
Conversation
This reverts commit 8154019.
@DinsFire64 @trevor403 can you guys please also test this? |
I've been testing Pokemon XD (mode0). |
Do you know other software that uses mode 0 (or 1, 2, 4, 5, 6)? Maybe we need to fix this 0->255 "Bug"? |
Sorry, I don't know of any software that uses anything other than mode0 and 3, and I don't have any... |
What do you mean by "other software"? Which game? |
I just merged this PR as I do not expect it to cause much additional trouble. It increases the sketch size by ~150 bytes, due to the additional convert method. |
@mizuyoukanao check this out. I've corrected the files accordingly. Can you please test this PR? What reading mode does pokemon XD use, so I can document that this mode is 100% tested? Did you also test the other modes?
Superceeds #25 #31 and #34