create symmetric fixed rank polar factory #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith transposed = true.
… path should be saved for future sessions.
…in two places, and also added a tip regarding FD's for gradient.
…earch_hint. On the other hand, it does require a hint in the problem structure, so that is now provided by default. I don't understand how this did not create bugs before.....
…mit of this file (RLBFGS) was made because of a bug on my computer (I was working with two versions of manopt, so that rlbfgs was calling an older verison of linesearch_hint, and that was the reason for the code not working; this being said, the newer version should be more robust anyway.)
…anifold (for example)
…rox of the Hessian in the checkhessian test.
…d by the user to explain what to expect in the case of FD approximations.
… call to a small built-in SVD -- using Brocket cost function. See if this is better numerically than the current truncated SVD in examples folder.
…gradient becomes very small
…ld be nice to maje it a stopping criterion.
…ions near fine convergence.
…ls that produce factories: all have M.tangent() defined.
|
Hello Bamdev, Thanks for the commits -- I have now reviewed your code and made a number of small and larger suggestions -- could you please check them out? Happy to discuss. Best, |
|
Hello Bamdev, Was there any issue with the recommendations I had made here? Thanks, |
|
Hello Nicolas,
All the changes are great.
How should I commit them? Do I need to just approve them? Or, do I need to
redo them from my side?
Regards,
Bamdev
…On Tue, Sep 17, 2019 at 3:14 AM Nicolas Boumal ***@***.***> wrote:
Hello Bamdev,
Was there any issue with the recommendations I had made here?
Thanks,
Nicolas
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=AFPRGI5OY5VJJYTZLXOF4TTQJ744PA5CNFSM4HDZ3Q72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62TSQQ#issuecomment-531970370>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFPRGIYRX34FZDVTCDF5TN3QJ744PANCNFSM4HDZ3Q7Q>
.
|
Typos Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
fixed the typos that Nicolas suggeted
…asBoumal/manopt into bmsymfixedrankpolarfactory
typos Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
Missing text Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
|
Got what to do next.
Will update.
Regards,
…On Tue, Sep 17, 2019 at 9:09 AM Bamdev Mishra ***@***.***> wrote:
Hello Nicolas,
All the changes are great.
How should I commit them? Do I need to just approve them? Or, do I need to
redo them from my side?
Regards,
Bamdev
On Tue, Sep 17, 2019 at 3:14 AM Nicolas Boumal ***@***.***>
wrote:
> Hello Bamdev,
>
> Was there any issue with the recommendations I had made here?
>
> Thanks,
> Nicolas
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#12?email_source=notifications&email_token=AFPRGI5OY5VJJYTZLXOF4TTQJ744PA5CNFSM4HDZ3Q72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62TSQQ#issuecomment-531970370>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFPRGIYRX34FZDVTCDF5TN3QJ744PANCNFSM4HDZ3Q7Q>
> .
>
|
Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
Adding description on the metric
to get matrix representation from the structure. and vice-versa.
symm(eta.B*(X.B\rgrad.B)) is same as symm(eta.B*symm(egrad.B)*X.B). Therefore, we need only 1 such term.
Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
Co-Authored-By: Nicolas Boumal <nicolasboumal@gmail.com>
Added " The total space is the Cartesian product of the Stiefel and symmetric % positive definite manifolds. An element in the total space, therefore, is % is also represented as a structure with two fields: U and B. This is % also the output in M.tangent2ambient."
added semicolon.
NicolasBoumal
force-pushed
the
master
branch
3 times, most recently
from
039d73a
to
917695d
Compare
This was referenced May 20, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the factory file for W = UBU' fixed rank geometry, where U is on the Stiefel and B is positive definite.