forked from bitcoin/bips
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exchange notifies processor of payments #1
Open
natefriedman
wants to merge
7
commits into
NicolasDorier:master
Choose a base branch
from
natefriedman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4f1f2cd - Browse repository at this point
Copy the full SHA 4f1f2cdView commit details
Commits on Jan 3, 2018
-
Exchange notifies processor of payments
The current proposal has the processor independently determine when payment is made. This adds significant complexity to each processor and creates the possibility that the processor thinks a payment was made when the exchange does not (or vice versa). Having the exchange notify the processor of payments via a webhook solves this. This is easier for the exchange to implement since they are already crypto experts, lowers the barrier for processor adoption (since they don't now need to be crypto experts), and ensures that invoices are marked as paid only when they really are.
Configuration menu - View commit details
-
Copy full SHA for c5f5bb4 - Browse repository at this point
Copy the full SHA c5f5bb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b24d8c6 - Browse repository at this point
Copy the full SHA b24d8c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5500bf - Browse repository at this point
Copy the full SHA e5500bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f29ed7b - Browse repository at this point
Copy the full SHA f29ed7bView commit details -
Merge pull request #1 from natefriedman/webhook
Exchange notifies processor of payments
Configuration menu - View commit details
-
Copy full SHA for 9a9c662 - Browse repository at this point
Copy the full SHA 9a9c662View commit details
Commits on Jan 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a0d4b30 - Browse repository at this point
Copy the full SHA a0d4b30View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.