Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output aspect ratio depends on input aspect ratio #5

Closed
FieserKiller opened this issue Feb 28, 2020 · 1 comment
Closed

Output aspect ratio depends on input aspect ratio #5

FieserKiller opened this issue Feb 28, 2020 · 1 comment

Comments

@FieserKiller
Copy link

There is a bug in line 74 of the code which calculates outX wrong for input files with an aspect ratio != 4:3. I noticed because my video was 5:4 and the output file was not 16:9.
Fix for converting all input files to 16:9 is quite trivial tho, simply calculate outX from input height * desired ratio:
outX := int(float64(specs.Streams[0].Height) * (16.0 / 9.0)) / 2 * 2 // multiplier of 2

Niek added a commit that referenced this issue Feb 28, 2020
@Niek
Copy link
Owner

Niek commented Feb 28, 2020

Thanks for reporting and providing the fix @FieserKiller! Fixed in 2689c70

@Niek Niek closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants