PERFORMANCE: J2N.Text.ValueStringBuilderChunkIndexer: Use ArrayPool for upperBounds array #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the int array (when we go over 32 chunks) for optimal memory reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upperBoundsarray is allocated only if we exceed 32 chunks or 65535 characters,. Being that this is a ref struct that is used once per method call, it makes sense to reuse the array if we spill over these values to make optimal use of memory.This makes
ValueStringBuilderChunkIndexerdisposable, but it is a fair tradeoff for what we gain.