Interface Logic of the Entry Dialog

[MatthiasJaeger]

When starting to use xDrip+ two weeks ago the way the entry dialog behaved was very unnatural for me. Whilst I have gotten used to it by now I feel that this might be an barrier to entry for new users.

When entering something in most systems this is done top to bottom. If doing so in the entry dialog in xDrip+ it means that you first enter the amount, then select if it is insulin or carbohydrates and then select the insulin type. This however doesn't work because the amount gets registered with whatever was selected at the bottom when it was entered.

I assume that the behavior is intended to allow for the entry of multiple things in one go. It could be made more logical by reordering the input elements such that the type selection is at the top followed by the insulin type selection with the numerical entry at the bottom. This should not be too intrusive a change for existing users and might prevent quite a few errors for new users.

Happy to create an issue for this or try to create a pull request if someone points me at where to start. I do have programming experience but not with phone apps.

[Navid200]

No, please don't start an issue.
Can you make it easier to understand what is not good. Can you use a diagram?

Looking at your text, I don't understand.
I personally, would never want to choose the amount before choosing what it is. so, I prefer to choose insulin before choosing the amount.

[MatthiasJaeger]

I agree, it feels more logical to choose what it is before choosing how much. It is just that with the current layout this means entering from the bottom-up instead of top-down.

Please see the diagram below. On the left hand side you see the interface as it currently is. The red entry order (top-down) is what would feel natural on this interface but doesn't work. The blue order is how one currently (and imho counter intuitively) has to enter the data. On the right hand side is the proposed change. Here the expected behavior is achieved by entering in the natural way (top-down, green entry order).

[Navid200]

Oh, now I understand. You are talking about the position of the items on the menu.
I cannot say that I personally have a preference.

I would say, you have two options.

One is to wait here and see if the repository owner would comment. He is the only one who would make yes or no decision about something like this.

The other option is to go ahead and open a PR: https://github.com/NightscoutFoundation/xDrip/pulls

Please note if anyone opens a PR, there is absolutely no guarantee that it will be accepted.

I can tell you a question that comes up almost always is this: Why do we need this?
And if the answer is "because I prefer it this way", that's not a very good answer.
If you can convince everyone why what we have could be confusing to the majority of the users, some of whom are already using the existing system, and why making this change is not going to cause further confusion, you may have a case.