Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G6 Temperature back #1722

Merged
merged 2 commits into from
Jul 10, 2021
Merged

G6 Temperature back #1722

merged 2 commits into from
Jul 10, 2021

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented May 12, 2021 •
edited
Loading

Subject Detail
Why do we need this? A G6 Firefly does not show the sensor temperature on the system status page now.
After this fix, it will.
Is there a work-around? The temperature is shown in the logs.
Are there any side-effects to this fix? No
Tests Has been tested with 2.27.2.98 and 2.27.2.103 firmwares.

@Navid200 Navid200 requested a review from jamorham May 12, 2021 03:17
tolot27
tolot27 approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@tolot27 tolot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite obvious. 👍

@tolot27 tolot27 added device-dexcom-transmitter next-build PRs to consider for the next build. labels May 12, 2021
@jamorham
Copy link
Collaborator

Can you let me know which firmware versions this has been tested with? Thanks

@Navid200
Copy link
Collaborator Author

@jamorham I personally have tested this with the following two firmware versions.
2.27.2.98
2.27.2.103

@Navid200
Copy link
Collaborator Author

Screenshot_20210521-090910

@Navid200 Navid200 mentioned this pull request May 22, 2021
Closed
7 tasks
@Navid200 Navid200 mentioned this pull request Jun 16, 2021
Closed
jamorham
jamorham approved these changes Jul 10, 2021
View reviewed changes
Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks logically correct but beware that temperature is only updated every 12 hours so its not really that useful to the end user and is more of a curiosity I would think. Maybe it should be hidden behind engineering mode to avoid being misleading.

@jamorham jamorham merged commit d8c84fb into NightscoutFoundation:master Jul 10, 2021
@Navid200 Navid200 deleted the TemperatureBack branch July 10, 2021 17:20
@Navid200
Copy link
Collaborator Author

@jamorham Thanks
How much battery energy does the transmitter use as a result of an enquiry?
We currently submit an enquiry once every 12 hours. What if we submit it once every half hour? What will be the impact on the battery life of the transmitter?

@tolot27 tolot27 removed the next-build PRs to consider for the next build. label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolot27 tolot27 tolot27 approved these changes

@jamorham jamorham jamorham approved these changes

Assignees
No one assigned
Labels
device-dexcom-transmitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Navid200 @jamorham @tolot27