Improved Factor and Device Token Handling #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the desired preferred factor doesn't exist, it will now list all available factors instead of displaying an empty list. Further, if a device token doesn't exist in the configuration file, it will be created on the first run instead of requiring the user to run the tool again with the
--action-register-device
flag.Related Issue
#93
Motivation and Context
Bad user experience having to run the tool again for the device token, and then an even worse experience when shown an empty list of factors, and no good reason as to why.
How Has This Been Tested?
Unit and user acceptance testing.
Types of changes
Checklist: