Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Factor and Device Token Handling #140

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Improved Factor and Device Token Handling #140

merged 1 commit into from
Oct 4, 2019

Conversation

Sector95
Copy link
Contributor

@Sector95 Sector95 commented Oct 4, 2019

If the desired preferred factor doesn't exist, it will now list all available factors instead of displaying an empty list. Further, if a device token doesn't exist in the configuration file, it will be created on the first run instead of requiring the user to run the tool again with the --action-register-device flag.

Related Issue

#93

Motivation and Context

Bad user experience having to run the tool again for the device token, and then an even worse experience when shown an empty list of factors, and no good reason as to why.

How Has This Been Tested?

Unit and user acceptance testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… If the desired preferred factor doesn't exist, it will now list all available factors instead of displaying an empty list.
@Sector95 Sector95 merged commit bf44385 into master Oct 4, 2019
@Sector95 Sector95 deleted the device-token branch October 4, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants