Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from AWS SDK 1.x to AWS SDK 2.x #12

Closed
wants to merge 2 commits into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 25, 2019

No description provided.

@sullis
Copy link
Contributor Author

sullis commented Feb 25, 2019

work in progress. FYI @jrduncans

@jrduncans
Copy link
Member

This might be better as an additional module than an upgrade. I foresee both versions of the AWS SDK coexisting for a while.

@sullis
Copy link
Contributor Author

sullis commented Feb 25, 2019

fyi: Java applications can use both SDKv1 and SDKv2 at the same time. Both AWS SDK's can co-exist on the classpath.

image

from this presentation: https://speakerdeck.com/sullis/aws-sdk-for-java-version-2-dot-0-dawscon-2019

@jrduncans
Copy link
Member

That's true, but was I still thinking people would prefer to pick the one they use rather than add additional dependencies, worry about any configuration differences, etc.

But perhaps I can see the point of view that the modules Moirai provides should be for the datastore, not the library used to access the datastore, and therefore we only need one S3 module and can change the implementation (although it will be a breaking change for construction).

@jrduncans
Copy link
Member

Redid this as part of #16

@jrduncans jrduncans closed this Dec 17, 2019
@sullis
Copy link
Contributor Author

sullis commented Dec 17, 2019

cool! @jrduncans

@sullis sullis deleted the aws-sdk-v2 branch December 17, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants