Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying content-length for HEAD requests or 304 status codes #103

Conversation

nicmunroe
Copy link
Member

No description provided.

@nicmunroe
Copy link
Member Author

@rabeyta some more response sending / RFC conformity stuff you may be interested in.

@sdford this should fix the issue with specifying content-length for HEAD responses.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #103 into master will decrease coverage by 0.25%.
The diff coverage is 78.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     91.47%   91.21%   -0.26%     
- Complexity     2124     2136      +12     
============================================
  Files           149      149              
  Lines          6137     6173      +36     
  Branches        803      813      +10     
============================================
+ Hits           5614     5631      +17     
- Misses          348      362      +14     
- Partials        175      180       +5
Impacted Files Coverage Δ Complexity Δ
...a/com/nike/riposte/server/config/ServerConfig.java 95.91% <ø> (ø) 36 <0> (ø) ⬇️
...poste/server/handler/RequestInfoSetterHandler.java 96.87% <ø> (ø) 15 <0> (ø) ⬇️
...ste/server/handler/RequestStateCleanerHandler.java 100% <ø> (ø) 13 <0> (ø) ⬇️
...server/channelpipeline/HttpChannelInitializer.java 100% <100%> (ø) 30 <0> (ø) ⬇️
...a/com/nike/riposte/server/http/ResponseSender.java 69.26% <76.66%> (-3.93%) 74 <25> (+9)
...r/handler/ProxyRouterEndpointExecutionHandler.java 61.25% <0%> (-2.5%) 27% <0%> (ø)
.../com/nike/riposte/server/logging/AccessLogger.java 96.29% <0%> (+1.48%) 48% <0%> (+1%) ⬆️
...ient/asynchttp/netty/StreamingAsyncHttpClient.java 76.51% <0%> (+1.62%) 49% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 513fda8...b545aaa. Read the comment docs.

@nicmunroe nicmunroe merged commit bebf355 into Nike-Inc:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants