FIX: account for mpl3.3 deprecation, mpl3.5 removal #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can no longer pass vmin, vmax, and norm to ScalarMappables. This was deprecated due to the ambiguity which vmin/vmax (the kwargs or the ones carried by the norm) should be used.
mrakitin
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Looks good to me, thanks for the quick fix, @tacaswell!
Suggested to align the pseudo-diagram in the comment, but that's not important.
| @@ -329,7 +333,7 @@ def __init__(self, fig, cmap=None, norm=None, | |||
| # Configure the figure in our own image | |||
| # | |||
| # +----------------------+ | |||
| # | H cross section | | |||
| # | H cross section | | |||
There was a problem hiding this comment.
Do we need to shift the borders above and below that too?
There was a problem hiding this comment.
This replaced a tab with spaces, should all be aligned now.
mrakitin
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can no longer pass vmin, vmax, and norm to ScalarMappables. This was
deprecated due to the ambiguity which vmin/vmax (the kwargs or the ones carried
by the norm) should be used.