Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notices for broken playlists #302

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Added notices for broken playlists #302

merged 3 commits into from
Jun 24, 2024

Conversation

NikkelM
Copy link
Owner

@NikkelM NikkelM commented Jun 24, 2024

No description provided.

@NikkelM NikkelM self-assigned this Jun 24, 2024
Copy link

todo-pr-checker bot commented Jun 24, 2024

There are 3 unresolved action items in this Pull Request:

src/config.js (1 action item):

// TODO: Revert when fixed
"shuffleOpenAsPlaylistOption": false,

src/html/popup/popup.js (1 action item):

// TODO: Revert when fixed
// v3.1.5: Playlist generation may be broken, open an overlay in the popup

static/html/popup.html (1 action item):

<!-- TODO: Remove when fixed -->
<div class="optionsRow-item">

Did I do good? Let me know by helping maintain this app!

@NikkelM
Copy link
Owner Author

NikkelM commented Jun 24, 2024

Related to #301

@NikkelM NikkelM merged commit e9c2fee into main Jun 24, 2024
1 of 2 checks passed
@NikkelM NikkelM deleted the fix-playlist branch June 24, 2024 17:28
@coveralls
Copy link
Collaborator

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9649749803

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 93.842%

Totals Coverage Status
Change from base Build 9530370369: 0.004%
Covered Lines: 1402
Relevant Lines: 1494

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants