separate conversion process from API #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, the `api` module was hosting the processing (the actual work) too. So if someone wanted to use just the SDK, would have run into issue if didnt have `api` dependencies. Now, module `cvfe.convert` contains the functionaly or the actual work, and `api` just contains a wrapper around it via `fastapi`.
Nikronic
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the
apimodule was hosting the processing (the actual work) too. So if someone wanted to use just the SDK, would have run into issue if didn't haveapidependencies. Now, modulecvfe.convertcontains the functionality or the actual work, andapijust contains a wrapper around it viafastapi. (see #59 on effort to make the package SDK friendly)