Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: rework CI script for more extensibility #26

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

NickVolynkin
Copy link
Contributor

@NickVolynkin NickVolynkin commented Jun 15, 2023

Rework script for more flexibility and extensibility:

  • Run any command in a container with --docker or in the current environment without this parameter.
  • Split compiling circuits and producing constraint & table, because further work with proof market requires the constraint only. Run each command as a separate step in CI.
  • Use single script for all commands. New commands with the proof-market-toolchain will use the same syntax.

The new script syntax is heavily inspired by
https://github.com/NilFoundation/dbms/blob/master/scripts/ci.sh

Follow-up to #5

@NickVolynkin NickVolynkin force-pushed the 5-rework-ci-script branch 2 times, most recently from 4c16c69 to c605d50 Compare June 15, 2023 08:32
Rework script for more flexibility and extensibility:

* Run any command in a container with `--docker` or in the current
  environment without this parameter.
* Split compiling circuits and producing constraint & table, because
  further work with proof market requires the constraint only.
  Run each command as a separate step in CI.
* Use single script for all commands. New commands with the
  proof-market-toolchain will use the same syntax.

The new script syntax is heavily inspired by
https://github.com/NilFoundation/dbms/blob/master/scripts/ci.sh

Follow-up to #5
Copy link

@knazarov knazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickVolynkin NickVolynkin merged commit 2eb7cda into master Jun 15, 2023
@NickVolynkin NickVolynkin deleted the 5-rework-ci-script branch June 15, 2023 09:28
@NickVolynkin NickVolynkin changed the title ci: rework CI script for more extensibility CI: rework CI script for more extensibility Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants