Allow setting tooltips

[jtotht]

The new tooltip field of the ListItem class makes it possible to add extended information as a tooltip. Also refactor the component a bit so that the new field needs to be handled only at one place.

Fixes #317

[jtotht]

Hi @NileshPatel17, could I get a review on this? It’s necessary to fulfill a business requirement, and we’re currently working it around by referencing a package built locally from my fork, but it results in extra work for each developer and a continuously dirty local Git repo in the dependent project (I can’t commit the change to package.json, as the local path is potentially different on each developer machine), so I’d like to return to the NPM version as soon as possible.

[NileshPatel17]

@jtotht will take a look, and if all looks good, will merge and publish new version.

[guerreda1095]

Hi @NileshPatel17 , have you taken a look at this Pull Request already, this is an important upgrade that will benefit many users. Thanks in advance!

[NileshPatel17]

@guerreda1095 added review comment, did not hear it back.. please fix it, and i will merge..

[guerreda1095]

@NileshPatel17 I'm not seeing any new pending comment to review, @jtotht are you able to see Nilesh's comments?

[jtotht]

No, I don’t see any review comments either, neither here nor in the diff view. Are you sure @NileshPatel17 that you actually published them?

[NileshPatel17]

No, I don’t see any review comments either, neither here nor in the diff view. Are you sure @NileshPatel17 that you actually published them?

I wonder, why you do not see review comment.

here is the link, https://github.com/NileshPatel17/ng-multiselect-dropdown/pull/371/files#diff-32a865e149b5c9b57ca8fa46f97a3499a97842afb9c36b5b076c9968e0fc3505

once you fix it, i will merge the code and publish new version.

[jtotht]

I also wonder (I haven’t encountered any such issues on GitHub before), but I still don’t see it – I see that your link leads me to the diff of multiselect.model.ts, but not your review comment. Maybe the easiest is that you paste your feedback here in the conversation instead of trying (and not succeeding) to use the inline comment feature.

[jtotht]

Or if you feel like it, you can do the changes yourself and push them to my fork so that they become part of this PR – as a maintainer, I’ve granted you push right to the 317-tooltips branch in my fork.

[NileshPatel17]

@jtotht please make below change. rest all is good. tooltip will always be string, can not be number.

replace this

export class ListItem {
  id: String | number;
  text: String | number;
  tooltip?: String | number | undefined;

with

export class ListItem {
  id: String | number;
  text: String | number;
  tooltip?: String | undefined;

[jtotht]

Good point, fixed.

[NileshPatel17]

@jtotht published new version 0.3.9. Pleaser test and let me know if it works or not.

its not working for me at least with angular 14
https://stackblitz.com/edit/angular-ivy-h7tdrm?file=src/app/app.component.ts

I get this error

Error: NG0302: The pipe 'multiSelectFilter' could not be found in the 'MultiSelectComponent' component. Verify that it is declared or imported in this module. Find more at https://angular.io/errors/NG0302

[jtotht]

Thanks for merging and publishing! I have no idea what’s going on with the StackBlitz example – I can’t go into the actual implementation files of ng-multiselect-dropdown (only in some TypeScript declaration files) on stackblitz.com, and when I download it, not even npm i succeeds due to conflicting package versions. In my own Angular 13 project, it works perfectly.

However, I do know why the CI job failed, so I submitted a PR to fix it: #379. (It would’ve been better if CI ran earlier, and I could fix the failure in this PR, but better late than never.)

[naveenpra17]

Hi team
Trying to add the tool tip in the multi select settings but it is not working. Can you please help
https://stackblitz.com/edit/ng-multiselect-dropdown-g8keem?file=src/app/app.component.ts

[jtotht]

You requested version 0.22.11 of this package. There’s no such version; the latest version (and the one that contains this pull request) is 0.3.9. I don’t know what NPM does when you specify a version that doesn’t exist, but don’t expect it to work.

[Rahul-codoffer]

@NileshPatel17 did you remove this feature in latest version [1.0.0] ?