Carry IP addresses for each port #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a really important change. It allows for hosts to have multiple interfaces and export the containers on the specified port. Static discovery will use any provided ports or will use the default published IP when this is not specified. HAproxy will default to using the hostname as before when the ports do not have IPs specified. When a Docker container reports a port with an IP address of 0.0.0.0, docker discovery will instead replace it with the default published IP address.
mihaitodor
approved these changes
Mar 31, 2017
| @@ -24,6 +24,7 @@ type Port struct { | |||
| Type string | |||
| Port int64 | |||
| ServicePort int64 | |||
| IP string | |||
There was a problem hiding this comment.
Small design question: why not use the net.IP type to store IPs?
There was a problem hiding this comment.
Because they are only used to write out text so doing that would just require parsing and generating strings over and over
|
LGTM too I'm forcing a DNS resolution in the traefik sidecar provider. With this change we should be able to relax that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really important change.
Static discovery will use any provided ports or will use the default published IP when this is not specified. HAproxy will default to using the hostname as beforewhen the ports do not have IPs specified. When a Docker container reports a port with an IP address of
0.0.0.0,DockerDiscoverywill instead replace it with the default published IP address.@felixgborrego @mihaitodor @bparli @intjonathan