Fix logging in fetchCheckForService #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relistan
reviewed
Sep 12, 2018
healthy/service_bridge.go
Outdated
| "Adding check for service %s (id: %s) failed. Got check type: %s, check args: %s.", | ||
| svc.Name, svc.ID, check.Type, check.Args, | ||
| ) | ||
| log.Warnf("Got empty check type for service %s (id: %s)!", svc.Name, svc.ID) |
There was a problem hiding this comment.
It looks to me like this got a little orphaned in the refactor at some point. But the new message should still show the args in case some were returned.
mihaitodor
force-pushed
the
mihaitodor/fix-log-message
branch
from
d7065a5
to
6218c49
Compare
mihaitodor
force-pushed
the
mihaitodor/fix-log-message
branch
from
6218c49
to
be50c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28. CheckForService will invoke
defaultCheckForServicewhencheck.Typeis not set via theHealthChecklabel explicitly on the service.