Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockets filter #41

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Rockets filter #41

merged 4 commits into from
Jul 25, 2023

Conversation

Kidd254
Copy link
Collaborator

@Kidd254 Kidd254 commented Jul 25, 2023

In this pull request I:

  • Created the ReservationItem component to render the name of a reserved service
  • Created the ReservedRockets component to render the list of reserved rockets
  • Created the MyProfile.css file to added the styles of the MyProfile page
  • Added the ReservedRockets components in My Profile view component

Copy link
Owner

@NitBravoA92 NitBravoA92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kidd254,

Well done! You have fulfilled all the requirements of the assigned task.

The application works perfectly fine, that's great!

There is nothing else to do other than... merge it :shipit:

Congratulations! 🎉

Highlights

✅ No linter error 👍

✅ You used Gitflow correctly 👍

✅ Good commit messages 👍

✅ Good descriptive PR 👍

✅ Good thought in creating a standalone component ReservationItem to render the name of a reserved service. This way you are reusing code. 👍

✅ You have done an excellent job creating the ReservedRockets component. You have used very well the useSelector hook to get the state data and display the list of reserved rockets. 👏

✅ Good job adding the new ReservedRockets component to the My Profile view. The information is displayed correctly. 👏

✅ Well done on creating the basic styles of the My Profile page 👏

Optional suggestions

_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

@Kidd254 Kidd254 merged commit 43035d5 into dev Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants