Skip to content

pine64-pinephone: fix front camera by raising CMA to 128MB #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pine64-pinephone: fix front camera by raising CMA to 128MB #392

wants to merge 1 commit into from

Conversation

tomfitzhenry
Copy link
Contributor

fixes #201

@tomfitzhenry
Copy link
Contributor Author

Ah, I just saw #201 (comment) , in particular:

Then, either configure a default at the kernel level, since we build bespoke kernels per-device we're free to do that. Or configure it through the device tree.

samueldr
samueldr requested changes Jul 23, 2021
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(As you saw)

Indeed, this shouldn't be fixed here.

The change should be done through a patch that we either:

  • Upstream to mainline Linux outright
  • Try to get into the de-facto community tree (megous')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr requested changes

Assignees
No one assigned
Labels
1. device: pinephone/pro
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinephone might need larger cma size for some things
2 participants
@tomfitzhenry @samueldr