Skip to content

Commit

Permalink
Revert "Merge pull request #3558 from LnL7/ssh-ng-stderr"
Browse files Browse the repository at this point in the history
This reverts commit 3ebfbec, reversing
changes made to c089c52.

#3558
  • Loading branch information
edolstra committed May 6, 2020
1 parent 909b4a8 commit fd49112
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
6 changes: 2 additions & 4 deletions src/libstore/remote-store.cc
Original file line number Diff line number Diff line change
Expand Up @@ -779,10 +779,8 @@ std::exception_ptr RemoteStore::Connection::processStderr(Sink * sink, Source *
return std::make_exception_ptr(Error(status, error));
}

else if (msg == STDERR_NEXT) {
string s = chomp(readString(from));
printMsg(lvlVomit, "stderr %s", s);
}
else if (msg == STDERR_NEXT)
printError(chomp(readString(from)));

else if (msg == STDERR_START_ACTIVITY) {
auto act = readNum<ActivityId>(from);
Expand Down
10 changes: 0 additions & 10 deletions src/libutil/logging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,6 @@ class SimpleLogger : public Logger
writeToStderr(prefix + filterANSIEscapes(fs.s, !tty) + "\n");
}

void result(ActivityId act, ResultType type, const std::vector<Field> & fields) override
{
if (type == resBuildLogLine || type == resPostBuildLogLine) {
assert(0 < fields.size());
assert(fields[0].type == Logger::Field::tString);
auto lastLine = fields[0].s;
log(lvlInfo, lastLine);
}
}

void startActivity(ActivityId act, Verbosity lvl, ActivityType type,
const std::string & s, const Fields & fields, ActivityId parent)
override
Expand Down

0 comments on commit fd49112

Please sign in to comment.