Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --arg-from-file and --arg-from-stdin #10122

Merged
merged 5 commits into from Mar 4, 2024
Merged

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Mar 1, 2024

Motivation

These read arguments from a file or from stdin, respectively. This is a cleaner alternative to builtins.readFile "/dev/stdin" (see #9330, #10019).

Context

Priorities and Process

Add 馃憤 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Mar 1, 2024
Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just a suggestion regarding the need for --arg-from-stdin, but looks great!

src/libcmd/common-eval-args.cc Show resolved Hide resolved
@edolstra edolstra enabled auto-merge March 4, 2024 11:50
@edolstra edolstra merged commit 4388559 into NixOS:master Mar 4, 2024
8 checks passed
@edolstra edolstra deleted the arg-from-file branch March 4, 2024 12:32
@drupol
Copy link
Contributor

drupol commented Mar 12, 2024

Does it mean we can not pass arguments to flake's ?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants