-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetchGit: allow fetching explicit refs #2582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fetch refs that are not in refs/heads currently fails because it looks for refs/heads/refs/foo instead of refs/foo. eg. builtins.fetchGit { url = https://github.com/NixOS/nixpkgs.git; ref = "refs/pull/1024/head; }
ajs124
added a commit
to ajs124/NixDroid
that referenced
this pull request
Feb 26, 2019
…or use needs nix with NixOS/nix#2582 merged
ajs124
added a commit
to ajs124/NixDroid
that referenced
this pull request
Feb 27, 2019
…or us needs nix with NixOS/nix#2582 merged (probably)
ajs124
added a commit
to ajs124/NixDroid
that referenced
this pull request
Feb 27, 2019
…or us needs nix with NixOS/nix#2582 merged (probably)
I wonder if this would address #2385 as well. |
Related issue on I really would like to see this in. |
+1 @edolstra anything blocking merging this? |
@edolstra Ping again |
I pushed a commit documenting this. |
BTW I just noticed we're not validating
|
jtanguy
added a commit
to jtanguy/nix
that referenced
this pull request
Sep 11, 2019
With the merge of NixOS#2582, the syntax "tags/1.9" for refs does not work anymore. However, the new syntax "refs/tags/1.9" seems to support annotated tags, such as "refs/tags/2.0". Closes NixOS#2385.
p01arst0rm
pushed a commit
to p01arst0rm/nix
that referenced
this pull request
Oct 2, 2019
With the merge of NixOS#2582, the syntax "tags/1.9" for refs does not work anymore. However, the new syntax "refs/tags/1.9" seems to support annotated tags, such as "refs/tags/2.0". Closes NixOS#2385.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fetch refs that are not in refs/heads currently fails because
it looks for refs/heads/refs/foo instead of refs/foo.
This enables some cool stuff like fetching the magic pull-request refs from github.