Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert VM tests to Python #4156

Merged
merged 2 commits into from Oct 17, 2020
Merged

Convert VM tests to Python #4156

merged 2 commits into from Oct 17, 2020

Commits on Oct 17, 2020

  1. Convert VM tests to Python 

    Perl-based tests are deprecated since NixOS 20.03 and subsequently got
removed in NixOS 20.09, which effectively means that tests are going to
fail as soon as we build it with NixOS 20.09 or anything newer.

I've put "# fmt: off" at the start of every testScript, because
formatting with Black really messes up indentation and I don't think it
really adds anything in value or readability for inlined Python scripts.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Oct 17, 2020
    Copy the full SHA
    5cfdf16 View commit details
    Browse the repository at this point in the history

  2. tests: Add names to VM tests 

    Having vm-test-run-unnamed for all the test derivation doesn't look very
nice, so in order to better distinguish them from their store path,
let's actually give them proper names.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Oct 17, 2020
    Copy the full SHA
    cfa26cf View commit details
    Browse the repository at this point in the history