Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aways register the realisations #4732

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Aways register the realisations #4732

merged 4 commits into from
Apr 23, 2021

Conversation

thufschmitt
Copy link
Member

Fix #4725

@thufschmitt thufschmitt added the ca-derivations Derivations with content addressed outputs label Apr 22, 2021
@thufschmitt thufschmitt force-pushed the 4725-always-register-the-realisations branch from 33a917a to 9161e02 Compare April 22, 2021 18:07
@Ericson2314
Copy link
Member

@regnat want to undo the nix-shell workaround then?

@thufschmitt
fixup! Add a regression test for #4725
6ea9c65
@thufschmitt
Revert "Make nix shell fallback to static outputs when needed"
d3df747 
This reverts commit 8d66f5f.

This fix isn't needed anymore now that the realisations are always
properly registered
@thufschmitt
Copy link
Member Author

@regnat want to undo the nix-shell workaround then?

Oh yes, of course. I've reverted it in d3df747

@edolstra edolstra merged commit 4549d65 into master Apr 23, 2021
@edolstra edolstra deleted the 4725-always-register-the-realisations branch April 23, 2021 12:22
@ldesgoui ldesgoui mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ca-derivations Derivations with content addressed outputs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that a built path always has an associated realisation
3 participants
@thufschmitt @Ericson2314 @edolstra