Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version number for DerivedPath changes #4763

Merged
merged 1 commit into from
May 3, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 2, 2021

I guess I misunderstood John's initial explanation about why wildcards
for outputs are sent to older stores[1]. My nix-daemon from 2021-03-26
also has version 1.29, but misses the wildcard[2]. So bumping seems to
be the right call.

However this now properly (I guess?) fixes errors like this:

$ nix-shell -A hello
error: derivation '/nix/store/zipc1j00q8i30xaylg0fz64lf2ypx752-bash-interactive-4.4-p23.drv' does not have wanted outputs '*'

[1] #4759 (comment)
[2] 255d145

cc @Ericson2314 @edolstra

I guess I misunderstood John's initial explanation about why wildcards
for outputs are sent to older stores[1]. My `nix-daemon` from 2021-03-26
also has version 1.29, but misses the wildcard[2]. So bumping seems to
be the right call.

[1] NixOS#4759 (comment)
[2] 255d145
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Sort of a funny thing to do after the fact, but I suppose it does help. (This is what I recommended, to be clear.)

@bjornfor
Copy link
Contributor

bjornfor commented May 3, 2021

Thanks! I was seeing the same issue with nix-env, but I haven't found the time to make an issue about it.

Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a bit unfortunate that we couldn’t catch this earlier, but nice to have it fixed now :)

@thufschmitt thufschmitt requested a review from edolstra May 3, 2021 09:32
@edolstra edolstra merged commit 6d2553a into NixOS:master May 3, 2021
@Ma27 Ma27 deleted the fix-nix-shell-error branch May 3, 2021 14:14
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/derivation-does-not-have-wanted-outputs-dev-out/12905/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants