Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixUnstable: pre20210326_dd77f71 -> pre20210429_d15a196 #121263

Merged
merged 2 commits into from
May 3, 2021

Conversation

thufschmitt
Copy link
Member

Motivation for this change

(amongst other things) several fixes to make the ca-derivations experimental feature usable on a daily basis

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 30, 2021

Result of nixpkgs-review pr 121263 at 5ce13431 run on aarch64-linux 1

2 packages failed to build:
6 packages built successfully:
  • disnix
  • disnixos
  • nix-direnv
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 121263 at 5ce13431 run on x86_64-linux 1

2 packages failed to build:
6 packages built successfully:
  • disnix
  • disnixos
  • nix-direnv
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review
2 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/tools/package-management/nix/default.nix:205:16:

        |
    205 |     patches = [(
        |                ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/tools/package-management/nix/default.nix:67:17:

       |
    67 |                 ./aws-sdk-cpp-TransferManager-ContentEncoding.patch
       |                 ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 30, 2021

Not sure if we want to upgrade if the tests didn't fully run https://github.com/NixOS/nix/runs/2470165209

@thufschmitt
Copy link
Member Author

Not sure if we want to upgrade if the tests didn't fully run https://github.com/NixOS/nix/runs/2470165209

That test is a know flaky test (see for example https://github.com/NixOS/nix/runs/2419910217 for another instance of it failing on master).

I’ve updated hydra too to catch-up with the Nix update. The dydisnix failure seems unrelated − the failure comes from libnixxml which doesn’t depend on nixUnstable

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 30, 2021
@Ma27
Copy link
Member

Ma27 commented May 1, 2021

@regnat OK, this shouldn't be merged as-is. nix-shell currently fails like this for me on nixpkgs on 78effd79f10:

→ ./result/bin/nix-shell -A hello                                                           [78effd79f10]
error: derivation '/nix/store/zipc1j00q8i30xaylg0fz64lf2ypx752-bash-interactive-4.4-p23.drv' does not have wanted outputs '*'

@Ma27
Copy link
Member

Ma27 commented May 1, 2021

According to git bisect the commit 255d145 is the problem.

@Ma27
Copy link
Member

Ma27 commented May 1, 2021

Opened NixOS/nix#4759 to fix this.

@Ma27
Copy link
Member

Ma27 commented May 2, 2021

Ok, seemed to be false alarm. You have to update your nix-daemon as well for getting this to work. New nix and 2.3 daemon appears to work, but not older(tm) unstable daemon & newer CLI. As this is still unstable software, this seems OK to me.

EDIT: the version number of the daemon protocol should be bumped retroactively to entirely get rid of this incompatibility.

@thufschmitt
Copy link
Member Author

Thanks for catching that @Ma27. Let’s wait for NixOS/nix#4763 to be merged first then

@thufschmitt
Copy link
Member Author

Just updated Nix with the fix mentionned above, should be good now!

(amongst other things) several fixes to make the `ca-derivations`
experimental feature usable on a daily basis
Required to work with the latest nixUnstable
@edolstra edolstra merged commit 946cc38 into NixOS:master May 3, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-11/12886/1

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants