Fix IFD with CA derivations #5807
Conversation
Rewrite the string taken by the IFD-like primops to contain the actual output paths of the derivations rather than the placeholders Fix #5805
thufschmitt
force-pushed
the
5805-ca-ifd
branch
from
c176b52
to
d90f9d4
Compare
| return res; | ||
| } | ||
|
|
||
| static Path realisePath(EvalState & state, const Pos & pos, Value & v, bool requireAbsolutePath = true) |
There was a problem hiding this comment.
What does requireAbsolutePath mean? I.e. when is it okay for it to be a relative path, and what is it relative to?
There was a problem hiding this comment.
requireAbsolutePath is here for the findFile primops (the desugaring of the angle brackets). Its first argument (the search path) can contain some strings with context, but these can be relative paths (which will then be relative to the cwd of the evaluator).
I’m not utterly happy having this flag just for that, but I’ve kept it to make sure to conserve the exact same semantics
(I had no idea that there could be strings-with-context here btw. Wonder whether that’s actually used anywhere)
|
I'm getting errors related to this commit: The getEnv in impure.nix is resolving to the empty string, but is still trying to access the overlays.nix. It's related to imports/paths, but I'm not sure exactly what is the root cause. |
Follow-up from #5807 to fix #5807 (comment)
Follow-up from #5807 to fix #5807 (comment)
Rewrite the string taken by the IFD-like primops to contain the actual output paths of the derivations rather than the placeholders
Fix #5805