Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly return false on builtins.pathExists /someNonAllowedPath #5826

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

thufschmitt
Copy link
Member

Follow-up from #5807 to fix #5807 (comment)

@thufschmitt
Copy link
Member Author

thufschmitt commented Dec 23, 2021

actually the fix is wrong because the new catch is too eager:

$ nix eval --expr 'builtins.pathExists (builtins.seq (builtins.readFile "/etc/hosts") /foo)'
false

^ that shouldn’t happen

EDIT: Should be good now

@thufschmitt thufschmitt marked this pull request as draft December 23, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants