Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bats for integration tests #7232

Closed
wants to merge 1 commit into from
Closed

Conversation

rapenne-s
Copy link
Member

this is a PR to modify the makefiles to use bats to handle integration tests, this PR can be used to compare with shellspec testing framework PR available at #7135

@Ericson2314
Copy link
Member

I don't get what is good abou tthis or #7135. It is very nice to have tests as separate make jobs so that parallelism is handled in a consistent way. The old setup where the integration tests did not run in parallel was terrible!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-38/22805/1

@rapenne-s
Copy link
Member Author

The current PRs are just for transitioning the tests toward a new framework, the tests will have to be rewritten. The PRs mostly just run the existing tests through a new framework, that's just the foundation to build upon it new tests.

You will get more explanation in the first message of #7135 (comment)

@Ericson2314
Copy link
Member

OK I get the motivation for individual tests somewhat, thanks, but I would still prefer to leverage make to be able to run the tests in parallel.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-39/23130/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants