Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RAPIDCHECK_HEADERS to nix-shell environment #8834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YorikSar
Copy link
Contributor

Motivation

Running ./configure in nix-shell environment currently ends up with this error:

checking for rapidcheck/gtest.h... no
configure: error: librapidcheck is not found.

There are workarounds in #7809, this change allows to run ./configure without them.

Context

See #7809 for more context.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 馃憤 to pull requests you find important.

Allows to run `./configure` in `nix-shell` environment without
additional workarounds. See NixOS#7809
for more context.

Related to NixOS#7809 (but doesn't fix it)
@YorikSar YorikSar mentioned this pull request Aug 16, 2023
@edolstra
Copy link
Member

Strange, this works fine for me (in nix-shell and nix develop).

@roberth
Copy link
Member

roberth commented Aug 16, 2023

Configuring for rapidcheck is a recurring theme now.
This could settle it once and for all:

@Ericson2314
Copy link
Member

The instructions are that one should run configurePhase, or perhaps ./configure $configureFlags. Plain running ./configure in the nix shell is not supported.

@Ericson2314
Copy link
Member

@roberth is write the underlying issue is rapidcheck being odd. emil-e/rapidcheck#302 didn't get a response but @YorikSar if you would like to make a PR to fix that issue, we can apply it as a patch in Nixpkgs before it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants