Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print positions in --debugger, instead of pointers #9913

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Print positions in --debugger, instead of pointers #9913

merged 1 commit into from
Feb 3, 2024

Conversation

9999years
Copy link
Contributor

@9999years 9999years commented Feb 3, 2024 •
edited
Loading

The --debugger currently prints the pointers of source code positions, rather than the positions themselves.

Before:

0: while evaluating the attribute 'python311.pythonForBuild.pkgs'
0x600001522598

After:

0: while evaluating the attribute 'python311.pythonForBuild.pkgs'
/nix/store/hg65h51xnp74ikahns9hyf3py5mlbbqq-source/overrides/default.nix:132:27

   131|
   132|       bootstrappingBase = pkgs.${self.python.pythonAttr}.pythonForBuild.pkgs;
      |                           ^
   133|     in

@github-actions github-actions bot added the repl The Read Eval Print Loop, "nix repl" command and debugger label Feb 3, 2024
@9999years
Copy link
Contributor Author

TODO: Needs a changelog entry.

@edolstra edolstra merged commit 49cf090 into NixOS:master Feb 3, 2024
9 checks passed
@9999years 9999years deleted the debugger-positions branch February 3, 2024 21:32
tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
Merge pull request NixOS#9913 from 9999years/debugger-positions
625df32 
Print positions in `--debugger`, instead of pointers

(cherry picked from commit 49cf090)
Change-Id: Ic27917b2aab3657c28d599898377bf0c14753f8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees
No one assigned
Labels
repl The Read Eval Print Loop, "nix repl" command and debugger
Projects
Nix team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9999years @edolstra