Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Techstack-beta] Donate: acknowledgement logos scale is off (in different ways) #1277

Closed
samueldr opened this issue Mar 3, 2024 · 0 comments · Fixed by #1300
Closed

[Techstack-beta] Donate: acknowledgement logos scale is off (in different ways) #1277

samueldr opened this issue Mar 3, 2024 · 0 comments · Fixed by #1300
Assignees
@garbas
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase

Comments

@samueldr
Copy link
Member

samueldr commented Mar 3, 2024

Both following screenshots are from the new implementation:

image
image

Observe the Hetzner and antithesis logos not scaling up like the others.

Combined to this issue here, the different scales picked for the logos here depending on the width of the window makes for an even more jumpy page than one would expect, with the logos going small, then medium, then small, then huge.
@samueldr samueldr added the design About the design refresh work label Mar 3, 2024
@thilobillerbeck thilobillerbeck added the new-techstack-beta This tag marks issues with the new tech stack during preview phase label Mar 3, 2024
@garbas garbas self-assigned this Mar 4, 2024
@garbas garbas linked a pull request Mar 4, 2024 that will close this issue
Fix acknowledgement logos on Donate page to scale better #1300
Merged
@thilobillerbeck thilobillerbeck mentioned this issue Mar 6, 2024
Merged
garbas added a commit that referenced this issue Mar 6, 2024
@thilobillerbeck @garbas
Fix image scalings and rework download page (#1311)
1be1506 
- closes #1277 
- closes #1276 
- closes #1287 
- closes #1292
- closes #1259 
- closes #1260 
- closes #1261 
- closes #1294

---------

Co-authored-by: Rok Garbas <rok@garbas.si>
thilobillerbeck added a commit that referenced this issue Mar 7, 2024
@thilobillerbeck @garbas
Fix image scalings and rework download page (#1311)
f2f159d 
- closes #1277 
- closes #1276 
- closes #1287 
- closes #1292
- closes #1259 
- closes #1260 
- closes #1261 
- closes #1294

---------

Co-authored-by: Rok Garbas <rok@garbas.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garbas garbas

Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix acknowledgement logos on Donate page to scale better NixOS/nixos-homepage
3 participants
@garbas @samueldr @thilobillerbeck