Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Techstack-beta] Site-wide: console and code blocks styles inconsistent #1292

Closed
samueldr opened this issue Mar 4, 2024 · 1 comment
Closed
Assignees
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase

Comments

@samueldr
Copy link
Member

samueldr commented Mar 4, 2024

Both inconsistent within the new site, and inconsistent with the previous implementation.


Here's a screenshot from the Download page, where the new implementation is proper for a commands block:

image


Here's, comparatively, a screenshot from the How Nix Works page, showing an off-model commands block:

image


You may have noticed I'm using commands block here. This is because a stylistic decision was made to have code blocks on light, and terminal sessions on dark.

Source code blocks are always off-model in the new implementation.

image


Side-note: the only story in the stories section is off-model in the old site.

@samueldr samueldr added the design About the design refresh work label Mar 4, 2024
@thilobillerbeck
Copy link
Collaborator

Will he part of a fix shortly

@thilobillerbeck thilobillerbeck added the new-techstack-beta This tag marks issues with the new tech stack during preview phase label Mar 4, 2024
garbas added a commit that referenced this issue Mar 6, 2024
- closes #1277 
- closes #1276 
- closes #1287 
- closes #1292
- closes #1259 
- closes #1260 
- closes #1261 
- closes #1294

---------

Co-authored-by: Rok Garbas <rok@garbas.si>
@garbas garbas closed this as completed Mar 6, 2024
thilobillerbeck added a commit that referenced this issue Mar 7, 2024
- closes #1277 
- closes #1276 
- closes #1287 
- closes #1292
- closes #1259 
- closes #1260 
- closes #1261 
- closes #1294

---------

Co-authored-by: Rok Garbas <rok@garbas.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase
Projects
None yet
Development

No branches or pull requests

3 participants