Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
nixos/tests/hibernate: Fix netcat flags
I'm not sure why 024b501 used -q 0 because even netcat-openbsd has the -N flag which IMO is the better way to shutdown the socket on EOF. Our default netcat implementation has changed once again[1] in 3c3b822 and we're now using LibreSSL's implementation, which doesn't have a -q flag. See #39634 for the pull request introducing the switch. [1]: #19982 Signed-off-by: aszlig <aszlig@nix.build> Cc: @matthewbauer, @dtzWill, @Mic92
- Loading branch information
146cb02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Looks good! Also if someone thinks there is a legit reason for using -q 0, we probably can modify https://sources.debian.org/patches/netcat-openbsd/1.105-7/0006-quit-timer.patch to apply to libressl.
146cb02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this netcat from debian should be actually called
netcat-debian
.