Make netcat-openbsd the default netcat #19982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sternenseemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @rycee and @edolstra to be potential reviewers. |
vcunat
reviewed
Oct 30, 2016
| netcat = callPackage ../tools/networking/netcat { }; | ||
| netcat = netcat-openbsd; | ||
|
|
||
| netcat-gnu = callPackage ../tools/networking/gnu-netcat { }; |
There was a problem hiding this comment.
Nitpick: the naming is rather inconsistent. I think it would be better to use netcat-gnu even for the directory name.
There was a problem hiding this comment.
Yeah, I had named it differently before, so a bit of regression, good point.
sternenseemann
force-pushed
the
netcat
branch
from
ffa7ee0
to
8f4f34b
Compare
Mic92
reviewed
Oct 30, 2016
| @@ -36,7 +36,7 @@ import ./make-test.nix (pkgs: { | |||
| $machine->waitForShutdown; | |||
| $machine->start; | |||
| $probe->waitForUnit("network.target"); | |||
| $probe->waitUntilSucceeds("echo test | nc -c machine 4444"); | |||
| $probe->waitUntilSucceeds("echo test | nc -q 0 machine 4444"); | |||
There was a problem hiding this comment.
Oh, it is not needed indeed, let me fix that.
The motivation for this change is the following: As gnu-netcat, e. g. does not support ipv6, it is not suitable as default netcat. This commit also fixes all obvious build issues caused by this change.
sternenseemann
force-pushed
the
netcat
branch
from
8f4f34b
to
bbe9159
Compare
|
\o/ |
johbo
added a commit
to johbo/nixops
that referenced
this pull request
Mar 9, 2017
Noticed that a call to "nixops ssh" did not work anymore after I upgraded the target host to the current 17.03 channel. Tracked the issue down to a change of the default netcat in the following PR: NixOS/nixpkgs#19982
rbvermaa
pushed a commit
to NixOS/nixops
that referenced
this pull request
Jul 24, 2017
Noticed that a call to "nixops ssh" did not work anymore after I upgraded the target host to the current 17.03 channel. Tracked the issue down to a change of the default netcat in the following PR: NixOS/nixpkgs#19982
aszlig
added a commit
that referenced
this pull request
Apr 29, 2018
I'm not sure why 024b501 used -q 0 because even netcat-openbsd has the -N flag which IMO is the better way to shutdown the socket on EOF. Our default netcat implementation has changed once again[1] in 3c3b822 and we're now using LibreSSL's implementation, which doesn't have a -q flag. See #39634 for the pull request introducing the switch. [1]: #19982 Signed-off-by: aszlig <aszlig@nix.build> Cc: @matthewbauer, @dtzWill, @Mic92
Synthetica9
pushed a commit
to Synthetica9/nixpkgs
that referenced
this pull request
May 3, 2018
I'm not sure why 024b501 used -q 0 because even netcat-openbsd has the -N flag which IMO is the better way to shutdown the socket on EOF. Our default netcat implementation has changed once again[1] in 3c3b822 and we're now using LibreSSL's implementation, which doesn't have a -q flag. See NixOS#39634 for the pull request introducing the switch. [1]: NixOS#19982 Signed-off-by: aszlig <aszlig@nix.build> Cc: @matthewbauer, @dtzWill, @Mic92
PsyanticY
pushed a commit
to PsyanticY/nixops-container
that referenced
this pull request
Jul 25, 2019
Noticed that a call to "nixops ssh" did not work anymore after I upgraded the target host to the current 17.03 channel. Tracked the issue down to a change of the default netcat in the following PR: NixOS/nixpkgs#19982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See Issue #19411.
TL;DR: netcat-gnu does neither support IPv6 nor unix sockets and is therefore not a good idea for a default netcat.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nixos/tests/hibernate.nixnixos/tests/virtualbox.nixbuild-support/vm/windowsI am open for suggestions on, how to test the windows vm build-support with GNU netcat.
A problem I see here is, that there is no standard deprecation process in nixpkgs (#15357). This change would certainly benefit from a
warnSemanticChangewhich I proposed in this PR: #19315.