Skip to content

Commit

Permalink
Merge pull request #314707 from ConnorBaker/fix/python3Packages.apric…
Browse files Browse the repository at this point in the history
…ot-select

python3Packages.apricot-select: fixup dependency categories and disable tests
  • Loading branch information
ConnorBaker committed May 27, 2024
2 parents a23b799 + 7568ee0 commit 2663954
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions pkgs/development/python-modules/apricot-select/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
lib,
buildPythonPackage,
fetchFromGitHub,
apricot-select,
numba,
numpy,
pynose,
Expand Down Expand Up @@ -37,15 +38,15 @@ buildPythonPackage rec {
dependencies = [
numba
numpy
scikit-learn
scipy
torchvision
tqdm
];

nativeCheckInputs = [
pynose
pytestCheckHook
scikit-learn
torchvision
];

pythonImportsCheck = [ "apricot" ];
Expand All @@ -56,6 +57,21 @@ buildPythonPackage rec {
"tests/test_optimizers/test_knapsack_feature_based.py"
];

# NOTE: These tests seem to be flaky.
disabledTests = [
"test_digits_modular"
"test_digits_modular_object"
"test_digits_modular_sparse"
"test_digits_sqrt_modular"
"test_digits_sqrt_modular_object"
"test_digits_sqrt_modular_sparse"
];

# NOTE: Tests are disabled by default because they can run for hours and timeout on Hydra.
doCheck = false;

passthru.tests.check = apricot-select.overridePythonAttrs { doCheck = true; };

meta = with lib; {
description = "Module for submodular optimization for the purpose of selecting subsets of massive data sets";
homepage = "https://github.com/jmschrei/apricot";
Expand Down

0 comments on commit 2663954

Please sign in to comment.