python3Packages.apricot-select: fixup dependency categories and disable tests #314707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependencies These are needed when building the package, not just during the checkPhase. This can be observed by setting doCheck to false.
ConnorBaker
added
0.kind: ZHF Fixes
|
Result of 4 packages built:
|
|
Result of 4 packages built:
|
ConnorBaker
force-pushed
the
fix/python3Packages.apricot-select
branch
from
a0d13a9
to
b1c46e1
Compare
ConnorBaker
changed the title
|
Result of 4 packages built:
|
|
Result of 4 packages built:
|
ConnorBaker
changed the title
|
Result of 4 packages built:
|
nbraud
approved these changes
May 26, 2024
natsukium
approved these changes
May 26, 2024
They can run for hours on Hydra: https://hydra.nixos.org/build/261011861
ConnorBaker
force-pushed
the
fix/python3Packages.apricot-select
branch
from
4e3ec06
to
7568ee0
Compare
|
Added a comment about why the tests are disabled by default. |
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR moves
scikit-learnandtorchvisiontodependenciesand out ofnativeCheckInputs, because they are required by the package. This can be observed by trying to build the package withdoCheck = false-- the build will fail, as they're no longer available.This PR also disables tests a handful of flaky tests which I've seen fail on and off.
Lastly, this PR disables the test suite by default, as it can take hours (or timeout entirely):
ZHF: #309482
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.