Skip to content

Commit

Permalink
nixos/ssh: don't accept ssh-dss keys
Browse files Browse the repository at this point in the history
These have been deprecated long enough.  I think this default was even
made non-functional by 2337c75.  But
it's still a scary thing to see there.

Fixes #33381.
  • Loading branch information
alyssais committed Apr 7, 2020
1 parent d7b9812 commit 387b9bf
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions nixos/modules/programs/ssh.nix
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,9 @@ in
'';
};

# Allow DSA keys for now. (These were deprecated in OpenSSH 7.0.)
pubkeyAcceptedKeyTypes = mkOption {
type = types.listOf types.str;
default = [
"+ssh-dss"
];
default = [];
example = [ "ssh-ed25519" "ssh-rsa" ];
description = ''
Specifies the key types that will be used for public key authentication.
Expand All @@ -75,9 +72,7 @@ in

hostKeyAlgorithms = mkOption {
type = types.listOf types.str;
default = [
"+ssh-dss"
];
default = [];
example = [ "ssh-ed25519" "ssh-rsa" ];
description = ''
Specifies the host key algorithms that the client wants to use in order of preference.
Expand Down

0 comments on commit 387b9bf

Please sign in to comment.