Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh client: remove DSA key support #33381

Closed
yorickvP opened this issue Jan 3, 2018 · 3 comments
Closed

ssh client: remove DSA key support #33381

yorickvP opened this issue Jan 3, 2018 · 3 comments
Labels
1.severity: security

Comments

@yorickvP
Copy link
Contributor

yorickvP commented Jan 3, 2018

Issue description

https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/programs/ssh.nix#L192-L194

ssh-dss was deprecated in 2015. Server support was removed in 17.03. It might be time to remove them client-side, and also from examples.
@aneeshusa
Copy link
Contributor

cc me as openssh maintainer to look at this later

lukateras added a commit that referenced this issue Mar 13, 2018
@lukateras
ssh: drop DSA support, fixes #33381
35066fd
@lukateras lukateras mentioned this issue Mar 13, 2018
Closed
@dotlambda dotlambda mentioned this issue May 24, 2018
Closed
@vcunat
Copy link
Member

vcunat commented Dec 9, 2018

Probably fixed by update #48784

@vcunat vcunat closed this as completed Dec 9, 2018
@alyssais
Copy link
Member

alyssais commented Apr 7, 2020

This is still being set through the NixOS option default.

@alyssais alyssais reopened this Apr 7, 2020
@yorickvP yorickvP mentioned this issue Apr 7, 2020
Merged
@edef1c edef1c closed this as completed in 387b9bf Apr 10, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Apr 10, 2020
@alyssais @dtzWill
nixos/ssh: don't accept ssh-dss keys
a59dd25 
These have been deprecated long enough.  I think this default was even
made non-functional by 2337c75.  But
it's still a scary thing to see there.

Fixes NixOS#33381.

(cherry picked from commit 387b9bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yorickvP @vcunat @aneeshusa @FRidh @alyssais